Skip to content

Products Onboarding: Adds a templateEligible property to productListAddProductTapped event #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2022
Merged

Products Onboarding: Adds a templateEligible property to productListAddProductTapped event #8072

merged 1 commit into from
Nov 9, 2022

Conversation

@Ecarrion
Copy link
Contributor

@Ecarrion Ecarrion commented Nov 9, 2022

Why

In order to properly identify which users should count toward the template experiment, this PR updates the productListAddProductTapped event to add a template-eligible property to be used as an exposure event on the Abacus experiment.

Screenshots

Screen Shot 2022-11-09 at 11 28 39 AM

Testing

  • Launch the app in a store with less than 3 products and tap the Add Product CTA
  • See that the event tracked has a template-eligible property with a true value
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@Ecarrion Ecarrion added the feature: products onboarding Related to onboarding new users to manage products label Nov 9, 2022
@Ecarrion Ecarrion added this to the 11.1 ❄️ milestone Nov 9, 2022
@peril-woocommerce
Copy link

peril-woocommerce bot commented Nov 9, 2022

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 2 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 9, 2022 •
edited
Loading

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8072-f0562ad on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@Ecarrion Ecarrion force-pushed the issue/update-exposure-event branch from 7ad3d66 to f0562ad Compare November 9, 2022 17:21
@Ecarrion Ecarrion merged commit 15d8e70 into release/11.1 Nov 9, 2022
@Ecarrion Ecarrion deleted the issue/update-exposure-event branch November 9, 2022 19:45
@oguzkocer oguzkocer mentioned this pull request Nov 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rachelmcr rachelmcr Awaiting requested review from rachelmcr

1 more reviewer

@ealeksandrov ealeksandrov ealeksandrov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: products onboarding Related to onboarding new users to manage products

Projects

None yet

Milestone

11.1

Development

Successfully merging this pull request may close these issues.

4 participants

@Ecarrion @wpmobilebot @ealeksandrov